https://bugs.kde.org/show_bug.cgi?id=400990
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kio
| |/4f5b4fd218ca40826300b59dad
| |d5d360b877b9d5
--- Comment #15 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 4f5b4fd218ca40826300b59dadd5d360b877b9d5 by David Edmundson.
Committed on 19/11/2018 at 21:54.
Pushed by davidedmundson into branch 'master'.
[ioslaves/trash] Handle broken symlinks in deleted subdirectories
Summary:
The trash ioslave currently handles:
- working symlinks at the toplevel
- broken symlinks at the toplevel
- working symlinks in subdirectories
but broken symlinks in a subdirectory get lost.
This is because subdirs are populated from a QDir::listEntries in the
subdirectory folder, which by default filters out broken symlinks.
It's important to list them so that we we restore the directory as
otherwise we lose data. The symlink could become non-dead once files are
restored.
Test Plan: Relevant unit test
Reviewers: dfaure
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17021
M +31 -1 src/ioslaves/trash/tests/testtrash.cpp
M +2 -0 src/ioslaves/trash/tests/testtrash.h
M +1 -1 src/ioslaves/trash/trashimpl.cpp
https://commits.kde.org/kio/4f5b4fd218ca40826300b59dadd5d360b877b9d5
--
You are receiving this mail because:
You are watching all bug changes.
