https://bugs.kde.org/show_bug.cgi?id=400906

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-browser-integration/cf6
                   |                            |d43ac605401062d5173e2409d7f
                   |                            |244f5cf9f9
         Resolution|---                         |FIXED

--- Comment #5 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit cf6d43ac605401062d5173e2409d7f244f5cf9f9 by Kai Uwe Broulik.
Committed on 03/12/2018 at 16:39.
Pushed by broulik into branch 'master'.

Install message handler after QApplication

When using qDebug et all we will use Connection::self()->sendMessage() to
forward that to the browser.
Connection uses a QSocketNotifier to listen to browser commands. This requires
a working event dispatcher.

When someone uses qDebug before QApplication initialized, e.g. qt5ct does this,
our QSocketNotifier
is defunct and we never receive any commands from the browser, breaking the
extension.

While stdout is reserved for communcation with the browser, where any random
debug output will have
the browser shut us down, qDebug prints on stderr which can be used for
printing debug output,
so no file descriptors are closed to prevent miscommunication.

CHANGELOG: Now also works when using qt5ct

Differential Revision: https://phabricator.kde.org/D17335

M  +2    -2    host/main.cpp

https://commits.kde.org/plasma-browser-integration/cf6d43ac605401062d5173e2409d7f244f5cf9f9

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to