https://bugs.kde.org/show_bug.cgi?id=402082

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Directly using `modelData`  |Directly using `modelData`
                   |isn't safe                  |in combobox isn't safe

--- Comment #1 from David Edmundson <k...@davidedmundson.co.uk> ---
The code does try to guard it:

org.kde.desktop/ComboBox.qml:        


text: controlRoot.textRole ? (Array.isArray(controlRoot.model) ?
modelData[controlRoot.textRole] : model[controlRoot.textRole]) : modelData


code in QQC1 was:


                text: popup.textRole === '' ?
                        modelData :
                          ((popup.modelIsArray ? modelData[popup.textRole] :
model[popup.textRole]) || '')



@Emmanuel could you test if that works for your "totally fine model"

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to