https://bugs.kde.org/show_bug.cgi?id=402529

David Faure <fa...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/ark
                   |                            |/d412ca6255230d809aa550891f
                   |                            |1af9049cf092d9
         Resolution|---                         |FIXED

--- Comment #2 from David Faure <fa...@kde.org> ---
Git commit d412ca6255230d809aa550891f1af9049cf092d9 by David Faure.
Committed on 15/01/2019 at 18:00.
Pushed by dfaure into branch 'Applications/18.12'.

Remember part URL to delete the tempfile even if the user used save as.

Summary:
Using the part URL at closing time is really dangerous: if the user used
"save as" (e.g. for an embedded PDF), we'll be deleting the file that
the user just saved!!

Test Plan:
launch ARK and open a ZIP file containing a PDF, click on the PDF,
an embedded viewer appears. From there, use "Save As..." to save the PDF
somewhere on your local disk. Close the embedded viewer, close ark.
It doesn't delete the saved file anymore.

Reviewers: elvisangelaccio, broulik

Reviewed By: elvisangelaccio

Subscribers: kde-utils-devel, #ark

Tags: #ark

Differential Revision: https://phabricator.kde.org/D18256

M  +3    -3    part/arkviewer.cpp
M  +1    -0    part/arkviewer.h

https://commits.kde.org/ark/d412ca6255230d809aa550891f1af9049cf092d9

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to