https://bugs.kde.org/show_bug.cgi?id=304816

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/2100a7a5c85931d46b72d3
                   |                            |91faa3d136d4401010
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |19.04.0

--- Comment #6 from Nate Graham <n...@kde.org> ---
Git commit 2100a7a5c85931d46b72d391faa3d136d4401010 by Nate Graham.
Committed on 19/01/2019 at 15:15.
Pushed by ngraham into branch 'master'.

Ask for confirmation when Closing Dolphin windows with a terminal panel running
a program

Summary:
Ask for confirmation when Closing Dolphin windows with a terminal panel running
a program.
FIXED-IN: 19.04.0

Test Plan:
# Open terminal panel
# Run `watch ls`
# Close Dolphin
# Observe confirmation
# Disable confirmation
# Repeat, observe no confirmation
# Enable confirmation in the settings
# Repeat, observe a confirmation

Reviewers: #dolphin, markg, elvisangelaccio, rominf

Reviewed By: #dolphin, elvisangelaccio

Subscribers: kfm-devel, elvisangelaccio, markg, ngraham, rkflx, broulik,
#dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10960

M  +53   -1    src/dolphinmainwindow.cpp
M  +13   -3    src/panels/terminal/terminalpanel.cpp
M  +3    -1    src/panels/terminal/terminalpanel.h
M  +4    -0    src/settings/dolphin_generalsettings.kcfg
M  +28   -0    src/settings/general/confirmationssettingspage.cpp
M  +5    -0    src/settings/general/confirmationssettingspage.h

https://commits.kde.org/dolphin/2100a7a5c85931d46b72d391faa3d136d4401010

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to