https://bugs.kde.org/show_bug.cgi?id=386379
--- Comment #41 from Dāvis <davis...@gmail.com> --- (In reply to Cqoicebordel from comment #39) > I understood that. > > I was just referencing the comment of Nate Graham > > I think the height of a single line of text might make sense. If that's not > > fast enough by default, we could do two or three. I'll experiment. > > and wanted to point out that doing it hardcoded, by the height of a single > line wasn't needed, as the setting I mentioned gives the users the choice of > number of lines of text to scroll. That's not possible if you use libinput, see bug #403842 (In reply to Nate Graham from comment #36) > I think the height of a single line of text might make sense. If that's not > fast enough by default, we could do two or three. I'll experiment. I don't think that's good approach. I've now been thinking about this and I think scroll speed shouldn't be related to item size at all. For example even in details view where each item is a line of text I want smooth scrolling and don't want to scroll by whole row because I might have 72 font which would make that as a huge jump too. Scrolling should be in device independent pixels (so taking into account DPI) and it should be user controllable setting (https://bugreports.qt.io/browse/QTBUG-73467) Also by the way, Dolphin isn't only application which does it wrong, this issue is also present in File dialog. Relevant API: * https://doc.qt.io/qt-5/qabstractitemview.html#verticalScrollMode-prop * https://doc.qt.io/qt-5/qabstractslider.html#singleStep-prop It looks like if we don't set singleStep then Qt default will be used based on verticalScrollMode. So I think it always should be ScrollPerPixel with a good default scroll speed. Also might consider that it could be based on window's size. For example if I have huge window I can scroll faster because there's so much space so that I'll still see all items but if window's is very small then I might want to scroll a lot slower so items don't move out of window too quickly. -- You are receiving this mail because: You are watching all bug changes.
