https://bugs.kde.org/show_bug.cgi?id=402784

David Hallas <da...@davidhallas.dk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/dol |https://commits.kde.org/dol
                   |phin/c72fdaa77380ef811dfef6 |phin/b1ccec70f28fefca8fcd46
                   |26a4edadbb824ed252          |4ec21dd13070c72e5c

--- Comment #11 from David Hallas <da...@davidhallas.dk> ---
Git commit b1ccec70f28fefca8fcd464ec21dd13070c72e5c by David Hallas.
Committed on 18/02/2019 at 19:21.
Pushed by hallas into branch 'Applications/18.12'.

Fix crash during shutdown

Summary:
Fix crash during shutdown. The root cause is that when Dolphin in stopped as
part of an activity, the KItemListViewAccessible destructor is called after
QApplication::exec has returned causing Qt to already having cleaned up the
QAccessibleInterface instances kept in KItemListViewAccessible. Instead of
storing the pointers to QAccessibleInterface we store the QAccessible::Id so
that we can use the QAccessible::deleteAccessibleInterface function for
deleting the instances.

Test Plan:
I wasn't able to reproduce the crash in the first place, but I have just
opened and closed Dolphin a few times and verified the the QAccessibleInterface
instances are correctly cleaned up.

Reviewers: #dolphin, elvisangelaccio, ngraham

Reviewed By: #dolphin, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19083

M  +15   -10   src/kitemviews/kitemlistviewaccessible.cpp
M  +7    -1    src/kitemviews/kitemlistviewaccessible.h

https://commits.kde.org/dolphin/b1ccec70f28fefca8fcd464ec21dd13070c72e5c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to