https://bugs.kde.org/show_bug.cgi?id=403038
--- Comment #5 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit 47be4be0209fd786b19c5066b96c8550a08c8746 by David Edmundson. Committed on 22/02/2019 at 14:40. Pushed by davidedmundson into branch 'master'. [scripting] Make DBus invokable run method return result after execution Summary: In 403038 the user expected the DBus call to run to finish before processing the next request. For a singleshot script that makes a lot of sense, otherwise you have no idea when it finishes. This also allows us to return errors. Test Plan: NUM=$(qdbus org.kde.KWin /Scripting org.kde.kwin.Scripting.loadScript /noFile.js Minimize) qdbus org.kde.KWin /$NUM org.kde.kwin.Scripting.run Error: org.kde.kwin.Scripting.FileError Could not open /noFile.js Running a real script behaved effectively the same as before. Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D18127 M +1 -0 autotests/CMakeLists.txt M +2 -0 autotests/tabbox/CMakeLists.txt M +20 -0 scripting/scripting.cpp M +5 -1 scripting/scripting.h https://commits.kde.org/kwin/47be4be0209fd786b19c5066b96c8550a08c8746 -- You are receiving this mail because: You are watching all bug changes.
