https://bugs.kde.org/show_bug.cgi?id=375725
Christoph Cullmann <cullm...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kat
| |e/0c15edfbd44fc8b094769b546
| |546ff7a9484cdf2
Resolution|--- |FIXED
Status|UNCONFIRMED UNCONFIRMED |RESOLVED RESOLVED
Latest Commit| |https://commits.kde.org/kat
| |e/0c15edfbd44fc8b094769b546
| |546ff7a9484cdf2
Resolution|--- |FIXED
--- Comment #2 from Christoph Cullmann <cullm...@kde.org> ---
Git commit 0c15edfbd44fc8b094769b546546ff7a9484cdf2 by Christoph Cullmann, on
behalf of loh tar.
Committed on 04/03/2019 at 18:54.
Pushed by cullmann into branch 'master'.
[RFC] Defuse KateMainWindow::showModOnDiskPrompt
Summary:
Related: bug 351443
Test Plan:
Fixed in a way as suggested in bug report.
Expected Results:
Exit without asking (file was not edited since last time in kate, so there is
no info to lose)
This dialog is for me pretty confusing and annoying.
- In which case may that question (without this patch) useful?
- Why should I reload a file when I like to close Kate?
- Click "Ignore" you will asked again, where you can overwrite the file on
disk. The opposite from your first intend.
- Click "Diff" keeps the dialog the focus with the result that you can't scroll
in the loaded diff. With dark theme is it hard to read too
- You can end in some "endless" dialog boxes
So, how about to remove that dialog?
{F6643583}
Reviewers: #kate, cullmann
Reviewed By: #kate, cullmann
Subscribers: cullmann, ngraham, kwrite-devel, #kate
Tags: #kate
Differential Revision: https://phabricator.kde.org/D19397
M +2 -1 kate/katemainwindow.cpp
https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2
--- Comment #1 from Christoph Cullmann <cullm...@kde.org> ---
Git commit 0c15edfbd44fc8b094769b546546ff7a9484cdf2 by Christoph Cullmann, on
behalf of loh tar.
Committed on 04/03/2019 at 18:54.
Pushed by cullmann into branch 'master'.
[RFC] Defuse KateMainWindow::showModOnDiskPrompt
Summary:
Related: bug 351443
Test Plan:
Fixed in a way as suggested in bug report.
Expected Results:
Exit without asking (file was not edited since last time in kate, so there is
no info to lose)
This dialog is for me pretty confusing and annoying.
- In which case may that question (without this patch) useful?
- Why should I reload a file when I like to close Kate?
- Click "Ignore" you will asked again, where you can overwrite the file on
disk. The opposite from your first intend.
- Click "Diff" keeps the dialog the focus with the result that you can't scroll
in the loaded diff. With dark theme is it hard to read too
- You can end in some "endless" dialog boxes
So, how about to remove that dialog?
{F6643583}
Reviewers: #kate, cullmann
Reviewed By: #kate, cullmann
Subscribers: cullmann, ngraham, kwrite-devel, #kate
Tags: #kate
Differential Revision: https://phabricator.kde.org/D19397
M +2 -1 kate/katemainwindow.cpp
https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2
--
You are receiving this mail because:
You are watching all bug changes.
