https://bugs.kde.org/show_bug.cgi?id=395012
Eike Hein <h...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/yak
| |uake/d9537fcba90ba912c8ea50
| |c4733d6189cdb15b01
Resolution|DUPLICATE |FIXED
--- Comment #9 from Eike Hein <h...@kde.org> ---
Git commit d9537fcba90ba912c8ea50c4733d6189cdb15b01 by Eike Hein, on behalf of
Lionel Chauvin.
Committed on 10/03/2019 at 07:30.
Pushed by hein into branch 'master'.
Fix Skin validation when installed from KNS
Summary:
When a Skin is downloaded from KNS, Yakuake fails to validate the presence of
title.skin and tabs.skin files.
The skin is then uninstalled even if these files exist.
This is due to this optimization of KNS: https://phabricator.kde.org/D6104
Files are not listed anymore by entry.installedFiles().
They are replaced by paths that end with /*
In order to fix this bug I changed the validateSkin method so that it checks
the presence of files in the filesystem instead of in a list of entries
returned by KNS.
Test Plan:
Download a Skin from KNS: It should not complain about missing files.
Install a correct skin from local: it should not complain about missing files;
Install a wrong skin from local: it should complain about missing files;
Install a correct skin already installed from local: it should ask for
overwrite existing skin.
Reviewers: hein, apol, #yakuake
Reviewed By: hein
Subscribers: Zren, hein, apol, chauvin
Tags: #yakuake
Differential Revision: https://phabricator.kde.org/D13335
M +45 -59 app/config/appearancesettings.cpp
M +4 -3 app/config/appearancesettings.h
https://commits.kde.org/yakuake/d9537fcba90ba912c8ea50c4733d6189cdb15b01
--
You are receiving this mail because:
You are watching all bug changes.
