https://bugs.kde.org/show_bug.cgi?id=383287
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/1f3ab6f7dddba
| |56679645ed12ebc07ff1f187e84
Status|CONFIRMED |RESOLVED
--- Comment #8 from Harald Sitter <sit...@kde.org> ---
Git commit 1f3ab6f7dddba56679645ed12ebc07ff1f187e84 by Harald Sitter.
Committed on 18/03/2019 at 11:06.
Pushed by sitter into branch 'Plasma/5.15'.
[service runner] throw out kde3 "compat" code
Summary:
Desktop files such as kde/foo.desktop are identified as kde-foo.desktop
because of the menu spec
```
If the directory contains sub-directories then these sub-directories should be
(recursively) scanned as well. The name of the subdirectory should be added as
prefix to the desktop-file id together with a dash character ("-")
```
the runner therefore broadly assumed that kde-foo.desktop is always
the desktop file kde/foo.desktop and since kde/ was only used up to KDE3
this assumption formed the basis for sepcial KDE3 compat handling. that is
of course wrong because a service might just as well actually have a
prefix and be actually called kde-foo.desktop rather than
kde/foo.desktop. Specific example: kde-gtk-config.desktop
seeing as this is ancient compatibility code that is actually wrong,
the easiest solution seems to be dropping the code entirely (and thus no
longer assume kde- has some special meaning).
(also I didn't find a way to get the underlying filename of a kservice,
so making the code not wrong seems non-trivial)
CHANGELOG: the GTK+ settings module now correctly appears in krunner and
kickoff
Test Plan: gtk kcm correctly shows up in both kickoff and krunner searches
Reviewers: broulik
Reviewed By: broulik
Subscribers: GB_2, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19788
M +1 -18 runners/services/servicerunner.cpp
https://commits.kde.org/plasma-workspace/1f3ab6f7dddba56679645ed12ebc07ff1f187e84
--
You are receiving this mail because:
You are watching all bug changes.
