https://bugs.kde.org/show_bug.cgi?id=406021

--- Comment #2 from James Harrison <ja...@talkunafraid.co.uk> ---
(In reply to Jasem Mutlaq from comment #1)
> It's getting checked again because KStars detects an older astrometry.net
> that requires it. Are you trying ti uncheck it for the "remote" option? What
> version do you have on the machine running KStars?

Aha! Right, this is all running locally and the local version is 0.77 from git
(using the Arch AUR packaging:
https://aur.archlinux.org/packages/astrometry.net/ ). The issue is in the Arch
packaging.

Looking at the OfflineAstrometryParser::init() function I see it's doing a
shell out to bash, running solve-field --help | grep Revision and looking for a
version number. I'm not sure what "good" looks like, but on my system that
yields:

Revision , date Tue_Nov_13_12:41:09_2018_+0800.

>From reading astronomy.net's code, after "Revision" should be the version tag
and git commit hash but this doesn't get done in from-source builds, only in
the release function. Even released source doesn't have this set, from my
reading; the AUR package is just grabbing the source release and building it.

I've worked around this by adding the following line to the AUR PKGBUILD's
prepare function:

sed "s/AN_GIT_REVISION .=.*/AN_GIT_REVISION := ${pkgver}/" -i
util/makefile.common

I will get this back into the AUR version.

It's probably safer to default to not using --nofits2fits and assuming a modern
build where there's no version information available, but this can be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to