https://bugs.kde.org/show_bug.cgi?id=406353

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/qca
                   |                            |/b38e904a4edce7bba33d687f0e
                   |                            |0b9dc5357ccbb6
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Harald Sitter <sit...@kde.org> ---
Git commit b38e904a4edce7bba33d687f0e0b9dc5357ccbb6 by Harald Sitter.
Committed on 23/04/2019 at 12:03.
Pushed by sitter into branch 'master'.

Partially revert "Require CMake 3.4 and use the OpenSSL imported libs"

Summary:
This reverts the QcaMacro changes of
commit 1137ed5f07d137296874f7dd1ee629f903507161 as they seem fairly
unrelated to the actual openssl change and proof to cause persistent issues
with buildability.

Further revert "unbreak build by moving away from deprecated exec_program"
This reverts commit 32419c899c77b8f5ece374d2453ee37e89af7c10.
Which was done in an attempt to remidy the build problems.

Further revert "Actually abort after the message that tells people to set
CMAKE_INSTALL_PREFIX"
This reverts commit 63fd27fbce780bccb9c9b3ff6649888cfd809c6a.
Which was also done in an attempt to fix the problems.

Test Plan:
- when configuring without any arguments the qmake derived paths are used and
correct
- when configuring with CMAKE_INSTALL_PREFIX the paths are accordingly reported
below that

QCA prefix is /opt
Plugins will be installed to /opt/lib/qca-qt5
Binary will be installed to /opt/bin
Library will be installed to /opt/lib
Public headers will be installed to /opt/include/Qca-qt5
Private headers will be installed to /opt/include/Qca-qt5
Feature file will be installed to /opt/mkspecs/features
Documentation will be installed to /opt/share/doc/qca-qt5/html
Man page will be installed to /opt/share/man
Pkg-config file will be installed to /opt/lib/pkgconfig

Reviewers: dfaure, arojas, vonreth

Reviewed By: dfaure, arojas

Differential Revision: https://phabricator.kde.org/D20408

M  +0    -1    CMakeLists.txt
M  +16   -10   cmake/modules/QcaMacro.cmake

https://commits.kde.org/qca/b38e904a4edce7bba33d687f0e0b9dc5357ccbb6

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to