https://bugs.kde.org/show_bug.cgi?id=407153
--- Comment #4 from Mauro Carvalho Chehab <mchehab+sams...@kernel.org> ---
(In reply to Wolfgang Bauer from comment #2)
> Hm, I meanwhile noticed that playback doesn't seem to work at all with vlc
> 2.2.6 anymore (works fine with 2.0.16)...
>
> So maybe it's better to just drop support for vlc < 3 completely?
Fixing it should probably be trivial. Either I forgot to add an event used on
vlc 2 to notify about playback status changes or we need to restore the diff
changes at makePlay() if vlc < 3. This was removed from makePlay, because it
was not required with vlc 3 (and/or broke something - don't remember the exact
issue I found on that time):
int VlcMediaWidget::makePlay()
{
if (vlcMedia == NULL) {
@@ -343,18 +578,7 @@ int VlcMediaWidget::makePlay()
return -1;
}
- libvlc_event_manager_t *eventManager =
libvlc_media_event_manager(vlcMedia);
- libvlc_event_e eventTypes[] = { libvlc_MediaMetaChanged };
-
- for (uint i = 0; i < (sizeof(eventTypes) / sizeof(eventTypes[0])); ++i)
{
- if (libvlc_event_attach(eventManager, eventTypes[i],
vlcEventHandler, this) != 0) {
- qCWarning(logMediaWidget, "Cannot attach event handler
%d", eventTypes[i]);
- }
- }
-
libvlc_media_player_set_media(vlcMediaPlayer, vlcMedia);
- libvlc_media_release(vlcMedia);
- vlcMedia = NULL;
--
You are receiving this mail because:
You are watching all bug changes.
