https://bugs.kde.org/show_bug.cgi?id=407165

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/spe
                   |                            |ctacle/32058e28dda5fd067746
                   |                            |66b3b8e4cfb7e57af689
   Version Fixed In|                            |19.04.1
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit 32058e28dda5fd06774666b3b8e4cfb7e57af689 by Nate Graham.
Committed on 05/05/2019 at 18:52.
Pushed by ngraham into branch 'Applications/19.04'.

Respect the user-configured mimetype when dragging an image from the main
window

Summary:
Currently, `ExportManager::tempSave()` expects a mimetype argument but defaults
to PNG.
However no users of that function actually pass it a mimetype, so
drag-and-dropped files
always get the PNG file format, even if the user changed the default file
format in the
settings window.

This patch changes the function to do away with the optional mimetype argument
and
instead always use the mimetype that the user has specified in the settings
window.
FIXED-IN: 19.04.1

Test Plan:
- Set the file format to JPEG
- Take a new screenshot
- Drag the image from the main window to somewhere else. It is created as a
JPEG file.

Reviewers: #spectacle, #kde_applications, davidre, nrother, #vdg, filipf

Reviewed By: #vdg, filipf

Subscribers: filipf

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D20976

M  +3    -1    src/ExportManager.cpp
M  +1    -1    src/ExportManager.h

https://commits.kde.org/spectacle/32058e28dda5fd06774666b3b8e4cfb7e57af689

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to