https://bugs.kde.org/show_bug.cgi?id=407721
Bhushan Shah <bhus...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pow
| |erdevil/90839c802ebc30c1fd4
| |6b54bc04a75fe1e7c3a47
Status|CONFIRMED |RESOLVED
--- Comment #7 from Bhushan Shah <bhus...@gmail.com> ---
Git commit 90839c802ebc30c1fd46b54bc04a75fe1e7c3a47 by Bhushan Shah.
Committed on 20/05/2019 at 12:35.
Pushed by bshah into branch 'Plasma/5.16'.
Set application name to org_kde_powerdevil
Summary:
Previously application component name without any KAboutData was
org_kde_powerdevil (executable name), although, 972eb26d0558d commit
changed the component name to powerdevil, which had side-effects that
powerdevil would write shortcuts to powerdevil component and it would
conflict with old org_kde_powerdevil shortcuts, and ultimately none
would work.
In theory we can do migration of the shortcuts to powerdevil component
using kconf_update but that doesn't work, as kglobalaccel is already
started before powerdevil, resulting in kconf_update changes having no
effect, more on this in commit 4ae36ddddae which introduces the
PowerDevilApp::migratePre512KeyboardShortcuts() function, while in
theory PowerDevilApp::migratePre516KeyboardShortcuts can be introduced,
we can simply avoid this hassle by re-assigning old component name.
Reviewers: davidedmundson, romangg
Reviewed By: davidedmundson
Subscribers: fvogt, arojas, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21303
M +2 -1 daemon/powerdevilapp.cpp
https://commits.kde.org/powerdevil/90839c802ebc30c1fd46b54bc04a75fe1e7c3a47
--
You are receiving this mail because:
You are watching all bug changes.
