https://bugs.kde.org/show_bug.cgi?id=403356
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/dol
| |phin/c22df71df28315b8b19646
| |71d3452fad5b6ae0f5
Resolution|--- |FIXED
Version Fixed In| |19.08.0
Status|CONFIRMED |RESOLVED
--- Comment #3 from Nate Graham <n...@kde.org> ---
Git commit c22df71df28315b8b1964671d3452fad5b6ae0f5 by Nate Graham.
Committed on 26/05/2019 at 03:32.
Pushed by ngraham into branch 'master'.
When filter bar is focused, switch to view when tab key is pressed
Summary:
Various people have requested that the tab key move keyboard focus from the
filter bar's
text edit field to the main view. It already does this when the Enter and
return keys
are pressed, but apparently this is not very intuitive and people expect Tab to
work too.
This patch makes that behavior possible by moving the Lock button to the left
of the
text edit field, and re-arranging the code so that the filter bar is
initialized first.
This works because Qt assigns tab ordering by default according to the order of
widget
construction. So if we simply construct the main view right after the filter
bar, then
the tab ordering is set up this way automatically.
Related: bug 403379
FIXED-IN: 19.08.0
Test Plan:
1. Activate Filter bar
2. Hit Tab key
3. View has become focused
4. Play around in Dolphin for a while and notice no regressions or crashes
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D21177
M +14 -12 src/dolphinviewcontainer.cpp
M +1 -1 src/filterbar/filterbar.cpp
https://commits.kde.org/dolphin/c22df71df28315b8b1964671d3452fad5b6ae0f5
--
You are receiving this mail because:
You are watching all bug changes.
