https://bugs.kde.org/show_bug.cgi?id=372789

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kwa
                   |                            |yland-integration/bfce3c672
                   |                            |7cdc58a2b8ba33c933df05e2191
                   |                            |4876
         Resolution|---                         |FIXED

--- Comment #46 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit bfce3c6727cdc58a2b8ba33c933df05e21914876 by David Edmundson.
Committed on 27/06/2019 at 08:37.
Pushed by davidedmundson into branch 'Plasma/5.16'.

Span wayland objects to lifespan of the QApplication

Summary:
We must release all wayland objects before the QPA connection is closed.

We used to do this explicitly, but this still left an awkward code path
where we could still try to recreate a BlurManager if it's called after
the QApplication is closed.

Instead we can scope all the wayland objects to the QApplication. The
objects themselves were not leaked as public API so this is safe. Calls
after this will simply no-op.

This fixes crashes on tear down of plasma.

Test Plan: kquitapp5 plasmashell

Reviewers: #plasma

Subscribers: apol, ngraham, anthonyfieroni, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22084

M  +17   -42   src/windowsystem/waylandintegration.cpp
M  +9    -8    src/windowsystem/waylandintegration.h

https://commits.kde.org/kwayland-integration/bfce3c6727cdc58a2b8ba33c933df05e21914876

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to