https://bugs.kde.org/show_bug.cgi?id=410802
Luca Beltrame <lbeltr...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Cantor tries to download |Cantor uses a bundled,
|data during building and |patched discount copy and
|the process is undocumented |fails to build if LANG is
| |not poperly set
--- Comment #2 from Luca Beltrame <lbeltr...@kde.org> ---
(In reply to Nikita Sirgienko from comment #1)
> "discount-2.2.6-patched.tar" placed in cantor/thirdparty directory. It is
It looks like it fails if LANG isn't properly set. If setting LANG to
"en_US.UTF-8" prior to building, it builds. I've edited the title to reflect
this.
That said, it is not acceptable for distros to have bundled third party deps
(unless you can disable the bundled copy and use the system one), nor that the
feature summary doesn't tell you that it's going to use a bundled library.
The README should also mention this.
> think, in future, I will send my Discount changes into master, but until the
> moment, I think, using embeded library version is the best option.
That won't fly with distributions for a lot of good reasons: what if the
bundled library does not build anymore for newer compilers? What if there is a
security vulnerability in the bundled library that is not patched? What if
there are bugs in the bundled library that are fixed in newer versions?
As this change is in master only, there is enough time for 19.12 to:
a. Submit discount changes upstream
b. Allow the build system to *not* use the bundled discount fork (because
that's what it is)
c. Write at the end of the cmake call whether a bundled library is being used
or not.
--
You are receiving this mail because:
You are watching all bug changes.
