https://bugs.kde.org/show_bug.cgi?id=408283
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |CONFIRMED
CC| |n...@kde.org
Ever confirmed|0 |1
--- Comment #2 from Nate Graham <n...@kde.org> ---
(In reply to Rafael Brandmaier from comment #1)
> Highlighter: A new icon is needed and should not be too hard to make.
+1
> Squiggle underline: A variant of format-text-underline should be possible.
+1
> Typewriter: While I can see why you like text-convert-to-regular, using that
> icon here is not quite semantically correct. I think it would be more
> standard to use either insert-text or insert-text-frame depending on whether
> the tool allows you to type freely or requires you to draw a bounding box
> for the text.
+1 for using one of those here rather than making a new icon. Can you mention
this in https://phabricator.kde.org/D15580?
> Inline note: note fits this quite well, but I do wonder if a insert-note
> icon with a little plus sign in the bottom right corner would be more
> appropriate.
+1, that sounds appropriate. Let's make sure to always use a plus sign in the
corner for tools that add new things seems like a good idea to me for
comprehensibility's sake.
> Arrow: A draw-arrow icon that looks like draw-line but with an arrowhead
> should fit nicely.
Yeah, and maybe we should add a little plus sign for this one too.
> Color and inner color: It might be easier to take the approach that Calligra
> and LibreOffice have regarding this (see attached screenshot), which is to
> use the format-text-color and format-fill-color icons and overlay a
> rectangle in the selected color on those. I think this approach is better
> because it ensures legibility of the icon regardless of the selected color
> and it is probably better for compatability with third party icon sets.
That does sound like it makes sense to me. Can you mention this in
https://phabricator.kde.org/D15580?
> Pin annotation: What do you think of window-pin? We can make a symlink to
> another name like edit-pinned or something like that.
The `pin` icon seems inaccurate since the icon depicts a location marker, not a
pin. I just fixed that with
https://commits.kde.org/breeze-icons/53bbac34aa2e755a06a4b0be21cf9b616d5e8769.
So now no changes are necessary to this in Okular.
--
You are receiving this mail because:
You are watching all bug changes.
