https://bugs.kde.org/show_bug.cgi?id=401916
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.63.0
Latest Commit| |https://commits.kde.org/kio
| |/f539b17ceec2a8c7a453228b7d
| |b62a7919b849be
--- Comment #13 from David Faure <fa...@kde.org> ---
Git commit f539b17ceec2a8c7a453228b7db62a7919b849be by David Faure, on behalf
of Ahmad Samir.
Committed on 15/09/2019 at 19:30.
Pushed by dfaure into branch 'master'.
KCoreDirLister: fix crash when creating new folders from kfilewidget
Summary:
When creating multiple nested new folders, one at a time, in the "save as"
dialog, where folders are created and entered, a dirlister would hit an
assert (in DirItem::reinsert()), because one of the created folders would
eventually get inserted in pendingUpdates.
Add a unit test in kfilewidgettest.
FIXED-IN: 5.63.0
Test Plan:
- Open a file in e.g. okular, then "save as"
- Create a new folder from the dialog, then another ... etc, usually 2-3
new folders would hit the assert (keep going, the number varies apparently)
and the app would crash
- Apply the patch then try again, it shouldn't crash
Reviewers: #frameworks, ahmadsamir
Subscribers: dhaumann, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23875
M +23 -0 autotests/kfilewidgettest.cpp
M +0 -6 src/core/kcoredirlister.cpp
https://commits.kde.org/kio/f539b17ceec2a8c7a453228b7db62a7919b849be
--
You are receiving this mail because:
You are watching all bug changes.
