https://bugs.kde.org/show_bug.cgi?id=412353
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kwi
| |n/3ba33e4b581f7d95effc481d4
| |7e553c392404e11
--- Comment #1 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 3ba33e4b581f7d95effc481d47e553c392404e11 by David Edmundson.
Committed on 26/09/2019 at 15:09.
Pushed by davidedmundson into branch 'Plasma/5.17'.
Use lambdas for queued invocation of composition suspending
Summary:
Qt's metaobject is rather sensitive with scope resolution.
Foo::Bar and Bar don't always match to a Qt metaobject, even if they
refer to the same thing to a compiler. Here we register
X11Compositor::SuspendReason but Q_ARG uses SuspendReason and they don't
match. This leads to a runtime failure where the method isn't invoked.
Rather than fixing metaobject usage, port the whole thing to lambdas
which does better compile time checking and is generally nicer to read.
Test Plan:
Ran xprop to block compositing. Compositing was blocked.
Grepped source code for Q_ARG use
Reviewers: #kwin, zzag
Reviewed By: #kwin, zzag
Subscribers: zzag, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D24244
M +9 -8 composite.cpp
M +4 -2 composite.h
M +4 -2 plugins/scenes/opengl/scene_opengl.cpp
https://commits.kde.org/kwin/3ba33e4b581f7d95effc481d47e553c392404e11
--
You are receiving this mail because:
You are watching all bug changes.
