https://bugs.kde.org/show_bug.cgi?id=371837
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Version Fixed In| |19.12.0
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/dol
| |phin/983273924d2887cdccdd7c
| |3618d332b52dc0dad6
--- Comment #12 from Nate Graham <n...@kde.org> ---
Git commit 983273924d2887cdccdd7c3618d332b52dc0dad6 by Nate Graham.
Committed on 29/09/2019 at 16:27.
Pushed by ngraham into branch 'master'.
Expose full set of script execution options in settings window
Summary:
Right now the script execution setting is a checkbox, capable only of handling
boolean
input. This is not appropriate because there are actually three options
available.
Accordingly, this patch replaces the checkbox with a combobox (to save space
compared
to radio buttons) that clearly exposes all three options.
FIXED-IN: 19.12.0
Test Plan:
{F7440559}
- All three options do what they say they'll do
- All options get saved properly
- The combobox displays the correct option when the window is loaded
- The {nav Defaults} button resets it to "always ask" as expected
Reviewers: elvisangelaccio, #dolphin, #vdg
Reviewed By: elvisangelaccio, #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Maniphest Tasks: T9932
Differential Revision: https://phabricator.kde.org/D24247
M +40 -9 src/settings/general/confirmationssettingspage.cpp
M +2 -1 src/settings/general/confirmationssettingspage.h
https://commits.kde.org/dolphin/983273924d2887cdccdd7c3618d332b52dc0dad6
--
You are receiving this mail because:
You are watching all bug changes.
