https://bugs.kde.org/show_bug.cgi?id=413044

Vlad Zahorodnii <vladz...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |5.17.2
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/a738ecce85c14b7cc4e7d1f3c
                   |                            |1c01c3db1c9c0e7
         Resolution|---                         |FIXED

--- Comment #5 from Vlad Zahorodnii <vladz...@gmail.com> ---
Git commit a738ecce85c14b7cc4e7d1f3c1c01c3db1c9c0e7 by Vlad Zahorodnii.
Committed on 25/10/2019 at 14:39.
Pushed by vladz into branch 'Plasma/5.17'.

[scripting] Provide conversion functions for AbstractClient

Summary:
If no conversion functions are provided for a QObject-subclass, then
QScriptEngine will use QScriptEngine::newQObject() method without any
special options to convert an instance of that QObject-subclass to a
QScriptValue. However, it's very important that every client object is
wrapped with PreferExistingWrapperObject option. We need that option
because a script may set a property on a client object and that property
must remain until it's deleted by the script.
FIXED-IN: 5.17.2

Test Plan: New test.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24944

M  +1    -0    autotests/integration/scripting/CMakeLists.txt
A  +170  -0    autotests/integration/scripting/minimizeall_test.cpp    
[License: GPL (v2)]
M  +15   -0    scripting/meta.cpp
M  +8    -0    scripting/meta.h
M  +12   -4    scripts/CMakeLists.txt

https://commits.kde.org/kwin/a738ecce85c14b7cc4e7d1f3c1c01c3db1c9c0e7

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to