https://bugs.kde.org/show_bug.cgi?id=413603
--- Comment #5 from Philippe Waroquiers <philippe.waroqui...@skynet.be> --- (In reply to Andreas Arnez from comment #3) > (In reply to Philippe Waroquiers from comment #2) > > * I am wondering if we should not allow comment lines starting with > > 0 or or spaces characters (like empty lines?) followed by # ? > I wondered about that, too. Actually my first version allowed whitespace > before the comment marker. But then I realized that callgrind_annotate > doesn't skip spaces at the beginning of a line in other cases, either. Thus > I adjusted my patch to be consistent with the rest of the logic. > Do you know of a case where it would be necessary to allow whitespace before > the comment marker? No, I had no specific example in mind, but as the callgrind format is quite general, I was afraid we might have a tool not in the valgrind tree producing such comment lines with spaces before #. I however just tried with kcachegrind, and it reports a warning for such # lines that have spaces before the #. So, I think that what you have done is ok. -- You are receiving this mail because: You are watching all bug changes.
