https://bugs.kde.org/show_bug.cgi?id=394348
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/sol
| |id/4aa39aed1bd6c81dbf0d6dc9
| |d312af5340f7caab
Version Fixed In| |5.65
--- Comment #91 from Nate Graham <n...@kde.org> ---
Git commit 4aa39aed1bd6c81dbf0d6dc9d312af5340f7caab by Nate Graham, on behalf
of Rok Mandeljc.
Committed on 12/11/2019 at 17:38.
Pushed by ngraham into branch 'master'.
[udisks2] fix media change detection for external optical drives
Summary:
If an external optical drive is connected after Solid does its initial
introspection, the resulting UDI does not get a mediaChanged signal/slot
connection, and thus fails to react to the media change. Consequently, disc
content is not properly updated after the medium is ejected, causing bug
#394348.
This patch assumes that an addition of "org.freedesktop.UDisks2.Block"
interface means that a new device has been added; in this case, it performs
Device::mightBeOpticalDisc() check to add the slotMediaChanged() connection.
FIXED-IN: 5.65
Test Plan:
Test steps:
1. Start KDE Plasma session. Make sure K3b is installed.
2. Connect an external USB optical drive.
3. Insert the disc
4. Observe Device action notifications for the inserted disc.
5. Eject the disc.
6. Observe Device action notifications.
Behavior before patch: after disc is ejected, a "Copy with K3b" action remains
available for the drive
See: https://bugs.kde.org/show_bug.cgi?id=394348
Behavior after patch: after disc is ejected, no actions remain available for
the drive
Reviewers: bruns, broulik, dfaure, #frameworks, ngraham
Reviewed By: ngraham
Subscribers: ngraham, bugseforuns, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20508
M +12 -0 src/solid/devices/backends/udisks2/udisksmanager.cpp
https://commits.kde.org/solid/4aa39aed1bd6c81dbf0d6dc9d312af5340f7caab
--
You are receiving this mail because:
You are watching all bug changes.
