https://bugs.kde.org/show_bug.cgi?id=391191
Dan Leinir Turthra Jensen <ad...@leinir.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.17.0
Latest Commit| |https://commits.kde.org/dis
| |cover/a4b6d2d5c25e3b9faf6b6
| |bd24edd503302175510
Resolution|--- |FIXED
--- Comment #3 from Dan Leinir Turthra Jensen <ad...@leinir.dk> ---
Git commit a4b6d2d5c25e3b9faf6b6bd24edd503302175510 by Dan Leinir Turthra
Jensen.
Committed on 11/12/2019 at 15:35.
Pushed by leinir into branch 'master'.
Add support for sub-comments to the Reviews backend
Summary:
Using a similar style to the comments delegate in KNewStuffQuick, this
adds the functionality for having subcomments in the Reviews model.
The end result is that we no longer have incorrect numbers showing in
Discover, as it now shows all the items returned by the server.
* Adds a role for the depth of reviews (used for comments on reviews)
* Adds sub-comments (and set their depth) in the KNS backend's reviews
* Adapts the ReviewDelegate to have indentation marks (styled like KNSQuick)
FIXED-IN: 5.17.0
Test Plan:
Without the patch, incorrect numbers of reviews are shown (as no children are
shown). With this patch, children are shown (using the same indentation style
as used by KNewStuffQuick):
{F7812653}
Reviewers: #discover_software_store, #plasma, apol, ngraham
Reviewed By: #discover_software_store, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25886
M +62 -42 discover/qml/ReviewDelegate.qml
M +3 -0 libdiscover/ReviewsBackend/ReviewsModel.cpp
M +2 -1 libdiscover/ReviewsBackend/ReviewsModel.h
M +15 -7 libdiscover/backends/KNSBackend/KNSReviews.cpp
https://commits.kde.org/discover/a4b6d2d5c25e3b9faf6b6bd24edd503302175510
--
You are receiving this mail because:
You are watching all bug changes.
