https://bugs.kde.org/show_bug.cgi?id=415317
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kwi
| |n/89024e2bcc1b2c2bae6bd75e8
| |5792cc67de9337c
--- Comment #7 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 89024e2bcc1b2c2bae6bd75e85792cc67de9337c by David Edmundson.
Committed on 06/01/2020 at 15:10.
Pushed by davidedmundson into branch 'master'.
Clamp XdgShellClient::clientSize to surface size, not m_windowGeometry
Summary:
It's perfectly legitimate to call setWindowSize before a buffer is
attached. This seems to have happen with plasma surfaces that commit
when attaching a shadow, but technically could happen anywhere.
By clamping to the applied surface here, we get the wrong window size
cached and not re-evaluated when a surface is eventually applied. This
leaves us thinking the windowsize is empty but with a massive margin
which actually holds the content.
We want all internal usages of xdgshellclient to use the window geometry
set. Only the wider kwin part needs to care about clamping it to the
surface.
This fixes popup placement in the plasma panel
As well as ghost notification popups with no background contrast that
you can't interact with.
Test Plan: Ran kwin
Reviewers: #kwin, zzag
Reviewed By: #kwin, zzag
Subscribers: romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D26233
M +22 -22 xdgshellclient.cpp
https://commits.kde.org/kwin/89024e2bcc1b2c2bae6bd75e85792cc67de9337c
--
You are receiving this mail because:
You are watching all bug changes.
