https://bugs.kde.org/show_bug.cgi?id=189482

--- Comment #11 from Méven Car <meve...@gmail.com> ---
Git commit 3f5341d3d7e23e3d1f160cd6f4d8188411d75f80 by Méven Car.
Committed on 06/01/2020 at 19:40.
Pushed by meven into branch 'master'.

Upstream Dolphin's file rename dialog

Summary:
KIO didn't actually have its own rename dialog, which is necessary to implement
the requested rename-from-the-file-dialog feature (189482). This patch
upstreams Dolphin's dialog so all KIO::FileWidgets users can use it.

The file's contents are copied from Dolphin and updated, but the name is
changed from `RenameDialog` to `RenameFileDialog` because `RenameDialog`
already exists in KIO (and is actually an //overwrite// dialog, but we can't
rename it until KF6).

Test Plan:
Apply D17596 or D17597 and initiate a rename operation for one or more files.
See that it works as expected.

Tests still pass.

Reviewers: #frameworks, #dolphin, broulik, ngraham, dfaure, elvisangelaccio

Reviewed By: #dolphin, ngraham, dfaure, elvisangelaccio

Subscribers: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp,
ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17595

M  +2    -0    src/widgets/CMakeLists.txt
A  +256  -0    src/widgets/renamefiledialog.cpp     [License: LGPL (v2+)]
A  +79   -0    src/widgets/renamefiledialog.h     [License: LGPL (v2+)]

https://commits.kde.org/kio/3f5341d3d7e23e3d1f160cd6f4d8188411d75f80

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to