[krita] [Bug 416000] 2 Internal Error(Safe Assert) messages when opening kra file that has vector layer

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=416000

Boudewijn Rempt <b...@valdyas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/kde/
                   |                            |krita/commit/7f7d98d9b1be23
                   |                            |0c0c5a95fc3809244d01f215e1
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit 7f7d98d9b1be230c0c5a95fc3809244d01f215e1 by Boudewijn Rempt.
Committed on 10/01/2020 at 10:02.
Pushed by rempt into branch 'master'.

Clear the activationLocks before deactivating the Stroke and Fill config
widgets

When loading a file with a vector layer, the node manager will
activate and deactivate the default tool in the wrong order. This
cannot be worked around; and in fact, we get a LOT of activate
and deactivate calls because just creating the config widgets will
call those:

KoStrokeConfigWidget::KoStrokeConfigWidget
DefaultToolTabbedWidget(0x562719ef0e00, name="default-tool-tabbed-widget")
KoFillConfigWidget::KoFillConfigWidget KoFillConfigWidget(0x562719f206a0)
KoFillConfigWidget::deactivate() KoFillConfigWidget(0x562719f206a0,
name="KoFillConfigWidget")  locks: 0
KoFillConfigWidget::activate() KoFillConfigWidget(0x562719f206a0,
name="KoFillConfigWidget") 2
KoStrokeConfigWidget::deActivate(): locks 0
KoFillConfigWidget::deactivate() KoFillConfigWidget(0x562719f206a0,
name="KoFillConfigWidget")  locks: 0
KoFillConfigWidget::KoFillConfigWidget KoFillConfigWidget(0x56271a039190)
KoFillConfigWidget::deactivate() KoFillConfigWidget(0x56271a039190,
name="KoFillConfigWidget")  locks: 0
KoFillConfigWidget::activate() KoFillConfigWidget(0x56271a039190,
name="KoFillConfigWidget") 2
KoStrokeConfigWidget::activate(): locks 2
KoFillConfigWidget::activate() KoFillConfigWidget(0x562719f206a0,
name="KoFillConfigWidget") 2
KoFillConfigWidget::deactivate() KoFillConfigWidget(0x56271a039190,
name="KoFillConfigWidget")  locks: 0
KoStrokeConfigWidget::deActivate(): locks 0
KoFillConfigWidget::deactivate() KoFillConfigWidget(0x562719f206a0,
name="KoFillConfigWidget")  locks: 0
KoFillConfigWidget::deactivate() KoFillConfigWidget(0x56271a039190,
name="KoFillConfigWidget")  locks: 2
SAFE ASSERT (krita): "d->deactivationLocks.empty()" in file
/home/boud/dev/krita/libs/ui/widgets/KoFillConfigWidget.cpp, line 358
KoStrokeConfigWidget::deActivate(): locks 2
SAFE ASSERT (krita): "d->deactivationLocks.empty()" in file
/home/boud/dev/krita/libs/ui/widgets/KoStrokeConfigWidget.cpp, line 481

M  +1    -4    libs/ui/widgets/KoFillConfigWidget.cpp
M  +1    -4    libs/ui/widgets/KoStrokeConfigWidget.cpp

https://invent.kde.org/kde/krita/commit/7f7d98d9b1be230c0c5a95fc3809244d01f215e1

-- 
You are receiving this mail because:
You are watching all bug changes.