https://bugs.kde.org/show_bug.cgi?id=416658

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/78eccc8bda2c898
                   |                            |d33c0efa731d7ce96a7b84d72
   Version Fixed In|                            |5.18.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit 78eccc8bda2c898d33c0efa731d7ce96a7b84d72 by Nate Graham.
Committed on 30/01/2020 at 15:43.
Pushed by ngraham into branch 'Plasma/5.18'.

[Folder View] Fix text label color in pop-up

Summary:
Currently there's a top-level ColorScope that is almost entirely unused except
for
introducing a bug whereby the label text in the pop-up is the wrong color.
Removing the
ColorScope fixes the bug and does not change the appearance of anything else
anywhere else.
FIXED-IN: 5.18.0

Test Plan:
Hover over a folder and click on button to open a folder pop-up
See that the text color is correct now: {F7925905, size=full}

Use Folder view as a containment, as a widget, and in a panel
See that text color is fine everywhere

Use a bunch of different color schemes and repeat the above tests and see that
everything
still looks good

Reviewers: #vdg, #plasma, hein, davidedmundson, mart

Reviewed By: #vdg, #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26884

M  +20   -30   containments/desktop/package/contents/ui/FolderViewLayer.qml

https://commits.kde.org/plasma-desktop/78eccc8bda2c898d33c0efa731d7ce96a7b84d72

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to