https://bugs.kde.org/show_bug.cgi?id=400725

Ahmad Samir <a.samir...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/efa5438e39bbff7bd1ade48120
                   |                            |b1d19fdea3a515
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #9 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit efa5438e39bbff7bd1ade48120b1d19fdea3a515 by Ahmad Samir.
Committed on 03/02/2020 at 08:40.
Pushed by ahmadsamir into branch 'master'.

[KOpenWithDialog] Automatically select the result if the model filter has only
one match

Summary:
If the user types some text in the lineEdit and there's more than one
match in the model view, don't automatically select the first match, so
that if the user presses Enter/Return, we don't load the first result
as it could well be not what the user actually wants.

Test Plan:
- Make sure ark and wireshark are installed on your system
- Invoke the open-with dialog on any archive file, and type ark
- You should get two results (or three if Ark is present in two individual
  categories on your system...) WireShark and Ark, with the former being
  automatically selected for you
- Press Enter, the file is opened with wireshark
- Apply the diff then try again, the open-with dialog will not select
  the first result, and if you press Enter the dialog will open the file
  using the command you typed

Reviewers: dfaure, ngraham, #frameworks, #vdg

Reviewed By: dfaure

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24951

M  +7    -5    src/widgets/kopenwithdialog.cpp

https://commits.kde.org/kio/efa5438e39bbff7bd1ade48120b1d19fdea3a515

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to