https://bugs.kde.org/show_bug.cgi?id=415200

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/8b3788ba3389c
                   |                            |85314f261415742b3470100f037
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 8b3788ba3389c85314f261415742b3470100f037 by David Edmundson.
Committed on 11/02/2020 at 13:48.
Pushed by davidedmundson into branch 'Plasma/5.18'.

[libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator

Summary:
VirtualDesktopInfo::Private is ref counted and shared between N
VirtualDesktopInfo's.

We were passing the first VirtualDesktopInfo as a parent to
VirtualDesktopInfo::Private which didn't manage the lifespan or do
anything useful.

The wayland backend incorrectly used this 'q' object and spanned
mulitple internal objects and connections to the first object that
created the shared private instance, leaving us with dangly objects
inside.
(and possibly several other bugs of wayland task manager not updating
correctly)

Test Plan:
Compiles
Plasma still loads

Reviewers: #plasma, zzag

Reviewed By: #plasma, zzag

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27266

M  +19   -21   libtaskmanager/virtualdesktopinfo.cpp

https://commits.kde.org/plasma-workspace/8b3788ba3389c85314f261415742b3470100f037

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to