https://bugs.kde.org/show_bug.cgi?id=298801

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |19.12.3
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |-extras/6832817f311bfa106ee
                   |                            |971ae51bac288843af08b
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #3 from Harald Sitter <sit...@kde.org> ---
Git commit 6832817f311bfa106ee971ae51bac288843af08b by Harald Sitter.
Committed on 13/02/2020 at 11:17.
Pushed by sitter into branch 'master'.

smb: fix free space calculation

Summary:
- collapse statvfs call, there's no purpose in manually opening the file
  when libsmbc has a convenience wrapper that does exactly what we need
  with less code on our end
- blockSize is now calculated as per the conditional branches in
  smbc_stat.c
- free space calculation is now backwards compatible with slightly busted
  legacy versions of libsmbc not setting f_bavail

FIXED-IN: 19.12.3

Test Plan: free space calculation now works with windows10, ubuntu18.04,
ubuntu19.10

Reviewers: ngraham, meven

Reviewed By: ngraham, meven

Subscribers: meven, kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D27294

M  +20   -17   smb/kio_smb_browse.cpp

https://commits.kde.org/kio-extras/6832817f311bfa106ee971ae51bac288843af08b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to