https://bugs.kde.org/show_bug.cgi?id=417238

--- Comment #3 from Aleksandar Rikalo <aleksandar.rik...@rt-rk.com> ---
In fact, in most cases of the Ity_I1 operations, the u32 field is used (e.g.,
vbits.c: 51). The u1 field is used only in few places (removed by the patch).
That isn't a problem on LE since unit8_t overlaps with LSB of uint32_t, but it
is a problem on BE.
Ity_I8, ..., Ity_I64 operations don't require any overlaps.

The other possible way to fix the test is to keep u1 field and replace all
usages of u32 for Ity_I1 purpose into u1. It seems like it would be more
complicated, especially because valgrind_[set|get]_vbits() functions (see
valgrind.c) have to be modified.

I'm looking at vbits.c and I'm not sure how much logic would be simplified by
eliminating the u8, ..., u32 fields (e.g., concat_vbits() function). I would
put that option aside.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to