https://bugs.kde.org/show_bug.cgi?id=417603
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/8f0da90f18ffa
| |69efdc485f137096f36aedb3909
--- Comment #10 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 8f0da90f18ffa69efdc485f137096f36aedb3909 by David Edmundson, on
behalf of Aleksei Nikiforov.
Committed on 06/03/2020 at 11:42.
Pushed by davidedmundson into branch 'Plasma/5.18'.
ItemContainer: disconnect signals in destructor
Summary:
Otherwise, setLayout function might be called for
already destructed instance of ItemContainer,
leading to double reference counter decrement of m_layout QPointer,
eventually invalidating such pointers prematurely.
Test Plan:
1) Unlock widgets via command: qdbus org.kde.plasmashell /PlasmaShell
evaluateScript "lockCorona(false)"
2) On desktop push right mouse button and select menu item 'Add Widgets...'
3) Add various widgets to desktop using drag'n'drop on desktop.
I've added at least following widgets on same desktop screen:
Audio Volume, Battery and Brightness, Binary Clock, Clipboard, Color Picker,
Grouping Plasmoid, Quick Chat
4) Remove just added widgets in random order
5) If necessary, repeat steps 3 and 4 a few times
If widgets aren't appearing on desktop despite adding them via drag'n'drop,
it's bugged and ready to crash. But it's not a requirement for crash.
6) lock widgets via command: qdbus org.kde.plasmashell /PlasmaShell
evaluateScript "lockCorona(true)"
7) repeat steps 1-6 multiple times
8) plasmashell shouldn't crash
Reviewers: ngraham, davidedmundson, mart
Reviewed By: davidedmundson
Subscribers: cfeck, anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27650
M +2 -0 components/containmentlayoutmanager/itemcontainer.cpp
https://commits.kde.org/plasma-workspace/8f0da90f18ffa69efdc485f137096f36aedb3909
--
You are receiving this mail because:
You are watching all bug changes.
