https://bugs.kde.org/show_bug.cgi?id=418385
--- Comment #3 from Kai Uwe Broulik <k...@privat.broulik.de> --- Git commit 503bf4f3a54267e22592c3e0ee246c20a2485a3d by Kai Uwe Broulik. Committed on 09/03/2020 at 08:21. Pushed by broulik into branch 'Plasma/5.18'. [gmenu-dbusmenu-proxy] Pass action "target" in invocation According to documentation [1] a menu item has a target attribute, which is "the parameter to pass when activating the action". Furthermore, the action "Activate" method specifies "If the action activation requires a parameter then this parameter must be given in the second parameter (av).". Also implements a TODO in the code. [1] https://wiki.gnome.org/Projects/GLib/GApplication/DBusAPI Differential Revision: https://phabricator.kde.org/D27884 M +7 -3 gmenu-dbusmenu-proxy/actions.cpp M +1 -1 gmenu-dbusmenu-proxy/actions.h M +6 -5 gmenu-dbusmenu-proxy/window.cpp M +1 -1 gmenu-dbusmenu-proxy/window.h https://commits.kde.org/plasma-workspace/503bf4f3a54267e22592c3e0ee246c20a2485a3d --- Comment #4 from Kai Uwe Broulik <k...@privat.broulik.de> --- Git commit ea358c896668a5c74ed8c405358c919e94adc8d7 by Kai Uwe Broulik. Committed on 09/03/2020 at 08:21. Pushed by broulik into branch 'Plasma/5.18'. [gmenu-dbusmenu-proxy] Fix radio button state detection Instead of comparing the state of the action to the action name, compare it to the argument the action will invoke it with. In contrast to checkboxes, which are independent actions with a boolean state, radio menu items all refer to the same action (e.g. "Zoom") and then pass the new state ("zoom-100", "zoom-200", etc) as target when invoking the action. Differential Revision: https://phabricator.kde.org/D27885 M +9 -12 gmenu-dbusmenu-proxy/window.cpp https://commits.kde.org/plasma-workspace/ea358c896668a5c74ed8c405358c919e94adc8d7 -- You are receiving this mail because: You are watching all bug changes.
