https://bugs.kde.org/show_bug.cgi?id=414055

--- Comment #14 from caulier.gil...@gmail.com ---
>Could you take a look at the patch and help me reverify these functionalities? 
>>If they haven't existed, can I have permission to add it to the code base of 
>>DInfoInterface?

Yes, typically, something is missing in digiKam interface (not the abstract
interface, and not for Showfoto).

For digiKam, if connection are missing as you comment in your patch here :

/*
    //TODO: port these slot from itemiconview_tags.cpp for Digikam, Image
Editor, Light Table but now Showfoto via DBInfoIface
    connect(slide, SIGNAL(signalRatingChanged(QUrl,int)),
            this, SLOT(slotRatingChanged(QUrl,int)));

    connect(slide, SIGNAL(signalColorLabelChanged(QUrl,int)),
            this, SLOT(slotColorLabelChanged(QUrl,int)));

    connect(slide, SIGNAL(signalPickLabelChanged(QUrl,int)),
            this, SLOT(slotPickLabelChanged(QUrl,int)));

    connect(slide, SIGNAL(signalToggleTag(QUrl,int)),
            this, SLOT(slotToggleTag(QUrl,int)));
*/

... connections must be established in constructor (or something like that):

https://invent.kde.org/kde/digikam/-/blob/master/core/libs/database/utils/ifaces/dbinfoiface.cpp#L281

... and signals emitted in this method:

https://invent.kde.org/kde/digikam/-/blob/master/core/libs/database/utils/ifaces/dbinfoiface.cpp#L476

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to