https://bugs.kde.org/show_bug.cgi?id=408512
Nicolas Fella <nicolas.fe...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://commits.kde.org/pri
| |nt-manager/9a11a1f4de8a2699
| |9485148c5a78e160e8880f17
Resolution|--- |FIXED
--- Comment #14 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit 9a11a1f4de8a26999485148c5a78e160e8880f17 by Nicolas Fella.
Committed on 12/03/2020 at 23:18.
Pushed by nicolasfella into branch 'master'.
Fix authentication
Summary:
According to the CUPS code
(https://github.com/apple/cups/blob/master/cups/auth.c#L105)
cupsDoAuthentication returns 0 on success and -1 on error. The code was
assuming the opposite
Now the CUPS password dialog is shown when needed. This is quite often, e.g
directly at startup due to getServerSettings() so it might be worth checking if
that's really necessary.
Test Plan: Open print-manager with a user that is not in a CUPS system group.
Privileged operations work after entering a password
Reviewers: dantti, broulik
Reviewed By: dantti
Subscribers: ognarb, rdieter, kde-utils-devel
Differential Revision: https://phabricator.kde.org/D23403
M +2 -2 libkcups/KCupsConnection.cpp
https://commits.kde.org/print-manager/9a11a1f4de8a26999485148c5a78e160e8880f17
--
You are receiving this mail because:
You are watching all bug changes.
