https://bugs.kde.org/show_bug.cgi?id=407845
Nate Graham <n...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |20.04.0 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://commits.kde.org/kde | |network-filesharing/8a104aa | |4fb4194708868fb58a5036ffa2e | |aec31d --- Comment #2 from Nate Graham <n...@kde.org> --- Git commit 8a104aa4fb4194708868fb58a5036ffa2eaec31d by Nate Graham. Committed on 15/03/2020 at 01:05. Pushed by ngraham into branch 'master'. Recommend rebooting after installing Samba Summary: After Samba is installed, very frequently it will not work correctly until the machine is rebooted. One potential reason is when the installed package has made group membership changes, which only take effect after a reboot. This patch implements a reboot recommendation along with a button to reboot the machine. Both are shown immediately after Samba has been installed. Because some expert users may understand the technical details of what's going on, the reboot is only recommended, not required. If the window is closed and then re-opened, the normal Samba sharing configuration UI is displayed instead of the reboot prompt. Added a new function rather than using a Lambda because it may be useful for additional purposes too (e.g. https://bugs.kde.org/show_bug.cgi?id=407846) FIXED-IN: 20.04.0 Test Plan: http://s1.webmshare.com/Ry55q.webm (not uploaded to Phab due to file size limit) 1. Remove Samba 2. Go to share a folder 3. Click "Install Samba" 4. After the installation has completed, click the "Restart" button and see that the machine reboots 5. Remove Samba again 2. Go to share a folder 3. Click "Install Samba" 4. Close the window and re-open it instead of rebooting as recommended 5. See that the Samba sharing config UI is all there Reviewers: #vdg, #frameworks, #dolphin, apol, sitter Reviewed By: sitter Subscribers: anthonyfieroni, sitter, bruns Differential Revision: https://phabricator.kde.org/D21466 M +25 -1 samba/filepropertiesplugin/sambausershareplugin.cpp M +5 -0 samba/filepropertiesplugin/sambausershareplugin.h https://commits.kde.org/kdenetwork-filesharing/8a104aa4fb4194708868fb58a5036ffa2eaec31d -- You are receiving this mail because: You are watching all bug changes.