https://bugs.kde.org/show_bug.cgi?id=417510
Dan Leinir Turthra Jensen <ad...@leinir.dk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED Latest Commit| |https://commits.kde.org/kne | |wstuff/f1dcbddf12ea44a13963 | |ce800223a2e683b2617d --- Comment #3 from Dan Leinir Turthra Jensen <ad...@leinir.dk> --- Git commit f1dcbddf12ea44a13963ce800223a2e683b2617d by Dan Leinir Turthra Jensen. Committed on 19/03/2020 at 10:34. Pushed by leinir into branch 'master'. Fix update scenarios with no explicit downloadlink selected Summary: The old downloadwidget's update system would explicitly require a user to pick which download item to use for updating if there was more than one available. This work is an attempt at implementing this at the engine level, while also allowing for there to be no requirement to make an active choice, unless there is no way to deduce which of the various potential download items is the one we are trying to update. The current heuristics are: - If there is one downloaditem, that's what we're updating - If there are more, first try and see if one has the precise url as the previously installed payload - If that fails, check for filename matches (without the rest of the url) - Only if that fails, present the user with a choice Add an explicit update function in the QtQuick items model Fix erroneous uses of installItem, and use updateItem for updates in the QtQuick components Reviewers: #knewstuff, #frameworks, #plasma, ngraham, apol, #discover_software_store, ahiemstra Reviewed By: ngraham, ahiemstra Subscribers: ahiemstra, alexde, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D27544 M +5 -0 CMakeLists.txt M +83 -1 src/core/engine.cpp M +2 -2 src/qtquick/qml/EntryDetails.qml M +2 -2 src/qtquick/qml/NewStuffItem.qml M +2 -2 src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml M +2 -2 src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml M +2 -2 src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml M +5 -0 src/qtquick/quickitemsmodel.cpp M +23 -0 src/qtquick/quickitemsmodel.h https://commits.kde.org/knewstuff/f1dcbddf12ea44a13963ce800223a2e683b2617d -- You are receiving this mail because: You are watching all bug changes.