https://bugs.kde.org/show_bug.cgi?id=418466
--- Comment #8 from Dan Leinir Turthra Jensen <ad...@leinir.dk> ---
Git commit eb23f549ea9b6fc893b73c29784c67a163aa47b3 by Dan Leinir Turthra
Jensen.
Committed on 06/04/2020 at 14:43.
Pushed by leinir into branch 'master'.
Introduce more user-visible error reporting for installations
Summary:
Prior to this, we did have error reporting, but only in the way of
writing errors out on the command line (through qCCritical). While
this is fine for debugging purposes, it is unfortunate when errors
can be expected to occur in day to day use (as we are dealing with
a wide range of things that can (and often do) go wrong), and giving
proper feedback to the user as to why, for example, their new icons
aren't showing up when they seem to have installed just fine would
seem a reasonable thing to do.
* Add a signal to Installation fired when there's a critical error
* Forward the installer errors through KNSCore::Engine
* Add the MessageBoxSheet component from kaccounts-integration
* Add a component for displaying errors from the engine
* Use the ErrorDisplayer component (only show on the current page)
Test Plan:
An error displayey thing:
{F8220509}
Reviewers: #knewstuff, #plasma, ngraham, #frameworks
Reviewed By: ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D28532
M +1 -0 src/core/engine.cpp
M +8 -1 src/core/installation.cpp
M +6 -0 src/core/installation.h
M +1 -0 src/qtquick/qml/EntryDetails.qml
M +1 -0 src/qtquick/qml/Page.qml
M +1 -0 src/qtquick/qml/private/EntryCommentsPage.qml
A +47 -0 src/qtquick/qml/private/ErrorDisplayer.qml [License: LGPL
(v2+)]
A +60 -0 src/qtquick/qml/private/MessageBoxSheet.qml [License: LGPL
(v2+)]
https://commits.kde.org/knewstuff/eb23f549ea9b6fc893b73c29784c67a163aa47b3
--
You are receiving this mail because:
You are watching all bug changes.
