https://bugs.kde.org/show_bug.cgi?id=211031

--- Comment #23 from Austin English <austinengl...@gmail.com> ---
I usually use -p1, so not sure what was wrong..anyway, recently tried again,
with a clean tree, and it applies fine, so yeah, it was something on my end.

With the patch, I see an improvement using badfree.c from the original post:

No patch:
==10542== Invalid free() / delete / delete[] / realloc()
==10542==    at 0x7BC70261: notify_free (heap.c:268)
==10542==    by 0x7BC70261: RtlFreeHeap.part.7 (???:0)
==10542==    by 0x7BC72034: RtlFreeHeap (heap.c:1748)
==10542==    by 0x516469D: msvcrt_heap_free (heap.c:114)
==10542==    by 0x51651DF: MSVCRT_free (heap.c:414)
==10542==    by 0x401599: ???
==10542==    by 0x401395: ???
==10542==    by 0x7B4504F1: ??? (in /usr/local/lib64/wine/kernel32.dll.so)
==10542==    by 0x7B4508DF: start_process (process.c:153)
==10542==    by 0x7B4504FD: ??? (in /usr/local/lib64/wine/kernel32.dll.so)
==10542==  Address 0x87654321 is on thread 1's stack
==10542== 

Patch:
==8665== Invalid free() / delete / delete[] / realloc()
==8665==    at 0x7BC70261: notify_free (heap.c:268)
==8665==    by 0x7BC70261: RtlFreeHeap.part.7 (???:0)
==8665==    by 0x7BC72034: RtlFreeHeap (heap.c:1748)
==8665==    by 0x516469D: msvcrt_heap_free (heap.c:114)
==8665==    by 0x51651DF: MSVCRT_free (heap.c:414)
==8665==    by 0x401599: _main (badfree.c:12)
==8665==    by 0x401395: ??? (crtexe.c:339)
==8665==    by 0x7B4504F1: ??? (in /usr/local/lib64/wine/kernel32.dll.so)
==8665==    by 0x7B4508DF: start_process (process.c:153)
==8665==    by 0x7B4504FD: ??? (in /usr/local/lib64/wine/kernel32.dll.so)
==8665==  Address 0x87654321 is on thread 1's stack
==8665== 

namely badfree.c:12 and crtexe.c:339. Note that there's some spurious output
from the patch, e.g.,:
size: 130284

@Julian, if feasible, it would be great to target this for valgrind-3.16.0.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to