https://bugs.kde.org/show_bug.cgi?id=421364

--- Comment #8 from Fabian Vogt <fab...@ritter-vogt.de> ---
Created attachment 128392
  --> https://bugs.kde.org/attachment.cgi?id=128392&action=edit
Add autotest

(In reply to Jonathan Marten from comment #7)
> Hopefully it is the right thing to do, because if running a desktop file
> then m_url has already been "consumed" to find the desktop file and it
> shouldn't be passed to the application.  After this has been done in
> runUrlWithMimeType() it and all its callers return immediately anyway, so
> m_url should not be needed any more.

Technically it's possible that some other method of job which uses m_url is
called after starting and some changes in the future might not expect that
m_url is empty at that point. IMO changing startService to take a url list is
cleaner.

(In reply to Fabian Vogt from comment #6)
> I'm currently working on an autotest for this.

Patch attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to