[krita] [Bug 421013] Magnetic Selection Crashes Program When Clicking More Than Once, or Dragging Too Far

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=421013

--- Comment #13 from Boudewijn Rempt <b...@valdyas.org> ---
Okay, there's another unchecked access, so this patch is better:

diff --git a/plugins/tools/selectiontools/KisMagneticWorker.cc
b/plugins/tools/selectiontools/KisMagneticWorker.cc
index f190006eb3..511c6831e6 100644
--- a/plugins/tools/selectiontools/KisMagneticWorker.cc
+++ b/plugins/tools/selectiontools/KisMagneticWorker.cc
@@ -177,7 +177,9 @@ void KisMagneticLazyTiles::filter(qreal radius, QRect
&rect)
     for (int i = firstTile.y(); i <= lastTile.y(); i++) {
         for (int j = firstTile.x(); j <= lastTile.x(); j++) {
             int currentTile = i * m_tilesPerRow + j;
-            if (radius != m_radiusRecord[currentTile]) {
+            if (m_radiusRecord.size() < currentTile
+                    && m_tiles.size() < currentTile
+                    && radius != m_radiusRecord[currentTile]) {
                 QRect bounds = m_tiles[currentTile];
                 KisGaussianKernel::applyTightLoG(m_dev, bounds, radius, -1.0,
QBitArray(), nullptr);
                 KisLazyFillTools::normalizeAlpha8Device(m_dev, bounds);


But... It seriously breaks the selection... I cannot get a good selection with
it anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.