https://bugs.kde.org/show_bug.cgi?id=421170
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/pla
| |sma-framework/c215c54eced5b
| |d0b195c208dd72bb580e65f8fe4
Status|REPORTED |RESOLVED
Resolution|--- |FIXED
--- Comment #15 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit c215c54eced5bd0b195c208dd72bb580e65f8fe4 by David Edmundson.
Committed on 14/05/2020 at 11:42.
Pushed by davidedmundson into branch 'master'.
Avoid potential disconnect of all signals in IconItem
Summary:
m_svgIcon can be null.
disconnect(q, nullptr, nullptr, nullptr); would have pretty catastrophic
consequences as it disconnects everything. Anyone listening for
QObject::destroyed of IconItem for cleanup would no longer get anything.
That could lead to obscure conditions.
ShaderEffectSource watches for the source being destroyed for cleanup
and we have a newly introduced crash with ShaderEffectSource that seems
to come from this patch.
Test Plan:
Someone who could reproduce the crash reliably confirms it fixes the
issue
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D29742
M +3 -1 src/declarativeimports/core/iconitem.cpp
https://commits.kde.org/plasma-framework/c215c54eced5bd0b195c208dd72bb580e65f8fe4
--
You are receiving this mail because:
You are watching all bug changes.
