https://bugs.kde.org/show_bug.cgi?id=411584
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit|https://commits.kde.org/pla |https://invent.kde.org/plas
|sma-desktop/1dd4668f1bf15e0 |ma/plasma-desktop/commit/e4
|57b841ce6e538073f1538ec27 |60fc4809c458ebc0a485db1e044
| |28271b9e328
--- Comment #35 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit e460fc4809c458ebc0a485db1e04428271b9e328 by David Edmundson.
Committed on 18/05/2020 at 10:52.
Pushed by davidedmundson into branch 'Plasma/5.19'.
[kcms/nightcolour] Reset needsSave after loading initial QML properties
Sequence of events is:
1) KCModule::showEvent()
2) this queues up a load and queues up a KCModule::changed(false)
3) during load ConfigModule::setNeedsSave(true) is called we set
d->_needsSave to true
4) we emit ConfigModule::changed(true) which we proxy through to
KCModule::changed(true)
5) we then process the queued KCModule::setChanged(false) from the
earlier KCModule::showEvent
6) so we disable the button
7) any subsequent changes in the KCM will call
ConfigModule::setNeedsSave(true)
but this now matches d->_needsSave so it no-ops. Even though KCModule is
out of sync.
Systemsettings only knows what KCModule signals, not ConfigModule.
This patch resets ConfigModule::d->_needsSave after step 3
See also https://phabricator.kde.org/D27384#611241
M +1 -0 kcms/nightcolor/kcm.cpp
https://invent.kde.org/plasma/plasma-desktop/commit/e460fc4809c458ebc0a485db1e04428271b9e328
--
You are receiving this mail because:
You are watching all bug changes.
