https://bugs.kde.org/show_bug.cgi?id=422155
Bug ID: 422155
Summary: Skrooge doesn't use per-locale bank icons
Product: skrooge
Version: Trunk from git
Platform: Flatpak
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: guillaume.deb...@gmail.com
Reporter: skierp...@gmail.com
CC: steph...@mankowski.fr
Target Milestone: ---
SUMMARY
Skrooge has a US-specific share/skrooge/images/logo/l10n/us/list_bank.txt file,
but it doesn't use it.
STEPS TO REPRODUCE
1. Somehow be in the USA.(set System Settings > Regional Settings > Formats >
Region? or modify ~/.config/plasma-localerc.)
2. Run Skrooge
3. Click Accounts, then click in the bank icon field.
OBSERVED RESULT
The pop-up shows the full of bank icons in
share/skrooge/images/logo/list_bank.txt , not the (much shorter) list of 7
banks in share/skrooge/images/logo/l10n/us/list_bank.txt/us/list_bank.txt
EXPECTED RESULT
Use the localized bank list.
SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: n/a
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.2
ADDITIONAL INFORMATION
The code in plugins/skrooge/skrooge_bank/skgbankpluginwidget.cpp attempts to
locate
QStandardPaths::GenericDataLocation, "skrooge/images/logo/l10n/" %
QLocale::countryToString(QLocale().country()) % "/list_bank.txt"
but according to SKGStatistic output in ~/.skrooge/ , my current.country is
"United States" (prior to May 2019 it has no space). Sure enough, if I copy the
"us" file to "United States", e.g. (for my flatpak)
$ cd /var/lib/flatpak/app/org.kde.skrooge/x86_64/master/active/files/
$ sudo cp -pir share/skrooge/images/logo/l10n/{us,United\ States}
and restart Skrooge, it does show the short US list of banks. The fix is to use
some other Qt logic that returns the shorter country code, maybe
QLocale::name()?
--
You are receiving this mail because:
You are watching all bug changes.
