https://bugs.kde.org/show_bug.cgi?id=423499
Bug ID: 423499
Summary: KFileItem::iconName ignorant of isSlow() and can block
gui thread
Product: frameworks-kio
Version: git master
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: kio-bugs-n...@kde.org
Reporter: sit...@kde.org
CC: kdelibs-b...@kde.org
Target Milestone: ---
```
if (isLocalUrl && !delaySlowOperations && isDir()) {
if (isDirectoryMounted(url)) {
d->m_iconName = iconFromDirectoryFile(url.toLocalFile());
```
if the file system is a mounted sshfs or cifs we'll read the .directory files
but really we shouldn't because they are network bound and may be slow.
Furthermore they may be backed by HDDs which may crumble under stress. Since
iconFromDirectoryFile does blocking POSIX reads this effectively means the gui
thread will block on slow network mounts.
isSlow() should be taken into consideration somewhere in that block.
--
You are receiving this mail because:
You are watching all bug changes.
