https://bugs.kde.org/show_bug.cgi?id=422554
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/netw
| |ork/kdenetwork-filesharing/
| |commit/6e7878af23a5db01afaa
| |51ed03f34e69dc31b4e0
Status|ASSIGNED |RESOLVED
Version Fixed In| |20.12
Resolution|--- |FIXED
--- Comment #8 from Harald Sitter <sit...@kde.org> ---
Git commit 6e7878af23a5db01afaa51ed03f34e69dc31b4e0 by Harald Sitter.
Committed on 20/08/2020 at 12:02.
Pushed by sitter into branch 'master'.
rejigger acl page and add a sheet to be shown when using a denial
denials always win so they shouldn't really be used unless one is
suuuuuuuuuuuuper sure about it.
to that end we'll throw up a warning that tries to explain that denials
probably aren't what the user wants and also that denying usually isn't
necessary because filesystem permissions still apply, so even when using
a liberal share ACL the filesystem ACL would still prevent other users
from reading one's private data for example
this was a bit awkward to implement because sheets need to overlay
something yet overlaying the columnlayout messes with the layout size
itself compacting the tableview away.
equally we cannot use a regular page because pages come with a whole
bunch of padding that looks very weird here and I've not found a way to
disable it either. instead we now have a new toplevel item which merely
acts as the thing the sheet can overlay. the item then contains the
previous layout and elements so they retain the sizing even when
overlayed
FIXED-IN: 20.12
M +173 -132 samba/filepropertiesplugin/qml/ACLPage.qml
https://invent.kde.org/network/kdenetwork-filesharing/commit/6e7878af23a5db01afaa51ed03f34e69dc31b4e0
--
You are receiving this mail because:
You are watching all bug changes.
